JingsongLi commented on PR #426: URL: https://github.com/apache/incubator-paimon/pull/426#issuecomment-1537029546
> > We should avoid copying `AbstractFlinkTableFactory`. We can use less codes to fix this. > > Then maybe we need to create a factory for DataTableSource, it will create DataTableSource for [flink-1](https://issues.apache.org/jira/browse/FLINK-1).14/[flink-1](https://issues.apache.org/jira/browse/FLINK-1).15 and create StatisticsDataTableSource for the later version of flink. What do you think? We can do like https://github.com/apache/incubator-paimon/pull/1010 , this may not look good, but we definitely need to avoid copying large amounts of code, which can be difficult to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
