JingsongLi commented on code in PR #1268:
URL: https://github.com/apache/incubator-paimon/pull/1268#discussion_r1211310323
##########
paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFileMeta.java:
##########
@@ -280,31 +299,65 @@ public static List<ManifestFileMeta> tryFullCompaction(
}
}
} else {
- // There is no DELETE Entry in Delta,Base don't need compaction
+ // There is no DELETE Entry in Delta, Base don't need
compaction
j = base.size();
result.addAll(base);
}
}
- Map<ManifestEntry.Identifier, ManifestEntry> fullMerged = new
LinkedHashMap<>();
+ // 2.2. try to skip base files by reading entries
+
Review Comment:
I feel also do not need, now this to check the cost should not be high, just
hashcode to compare
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
