JingsongLi commented on code in PR #1414:
URL: https://github.com/apache/incubator-paimon/pull/1414#discussion_r1236382826


##########
docs/content/api/java-api.md:
##########
@@ -592,10 +592,22 @@ public class StreamWriteTable {
 
         // 3. Collect all CommitMessages to a global node and commit
         StreamTableCommit commit = writeBuilder.newCommit();
-        commit.commit(commitIdentifier, messages);
-
-        // 4. When failover, you can use 'filterCommitted' to filter committed 
commits.
-        commit.filterCommitted(committedIdentifiers);
+        boolean firstTry = true;

Review Comment:
   Here is very confused...
   Actually, when failure occurs, just `filterAndCommit` messages in state, and 
use commit for new messages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to