yuzelin commented on code in PR #1443:
URL: https://github.com/apache/incubator-paimon/pull/1443#discussion_r1252466819
##########
paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java:
##########
@@ -77,6 +80,40 @@ public void createTag(Snapshot snapshot, String tagName) {
}
}
+ public void deleteTag(
+ String tagName, TagDeletion tagDeletion, SnapshotManager
snapshotManager) {
+ checkArgument(!StringUtils.isBlank(tagName), "Tag name '%s' is
blank.", tagName);
+ checkArgument(tagExists(tagName), "Tag '%s' doesn't exist.", tagName);
+
+ Snapshot taggedSnapshot = taggedSnapshot(tagName);
+ List<Snapshot> taggedSnapshots = taggedSnapshots();
Review Comment:
Cannot do it because delete the tag file will make the taggedSnapshots
return wrong result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
