JingsongLi commented on code in PR #1500:
URL: https://github.com/apache/incubator-paimon/pull/1500#discussion_r1259612984
##########
paimon-core/src/main/java/org/apache/paimon/io/KeyValueFileWriterFactory.java:
##########
@@ -43,36 +43,43 @@ public class KeyValueFileWriterFactory {
private final long schemaId;
private final RowType keyType;
private final RowType valueType;
- private final FormatWriterFactory writerFactory;
- @Nullable private final TableStatsExtractor tableStatsExtractor;
- private final DataFilePathFactory pathFactory;
+ private final RowType recordType;
+ private FormatWriterFactory writerFactory;
+ @Nullable private TableStatsExtractor tableStatsExtractor;
+ private DataFilePathFactory pathFactory;
Review Comment:
Here we should maintain a `Map<String, Factories>` field to deal with
different formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
