JingsongLi commented on code in PR #1564:
URL: https://github.com/apache/incubator-paimon/pull/1564#discussion_r1264828198
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/kafka/KafkaSyncTableAction.java:
##########
@@ -156,15 +156,7 @@ public void build(StreamExecutionEnvironment env) throws
Exception {
table = (FileStoreTable) catalog.getTable(identifier);
KafkaActionUtils.assertSchemaCompatible(table.schema(), fromCanal);
} catch (Catalog.TableNotExistException e) {
- Schema schema =
- KafkaActionUtils.buildPaimonSchema(
- kafkaSchema,
- partitionKeys,
- primaryKeys,
- computedColumns,
- paimonConfig,
- caseSensitive);
- catalog.createTable(identifier, schema, false);
+ catalog.createTable(identifier, fromCanal, false);
table = (FileStoreTable) catalog.getTable(identifier);
Review Comment:
KafkaSchema.parseCanalJson can use CanalRecordParser?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
