Aitozi commented on code in PR #1557:
URL: https://github.com/apache/incubator-paimon/pull/1557#discussion_r1272235620
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/FullChangelogMergeFunctionWrapper.java:
##########
@@ -110,8 +112,9 @@ public ChangelogResult getResult() {
} else {
if (merged == null || !isAdd(merged)) {
reusedResult.addChangelog(replace(reusedBefore,
RowKind.DELETE, topLevelKv));
- } else if (!changelogRowDeduplicate
- || !valueEqualiser.equals(topLevelKv.value(),
merged.value())) {
+ } else if (!isFirstRow
Review Comment:
I have not come up with a good wrapper to handle this, but I improve the
logic in `FullChangelogMergeFunctionWrapper` with a short-cut for first row
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
