s7monk commented on code in PR #15:
URL:
https://github.com/apache/incubator-paimon-webui/pull/15#discussion_r1275836468
##########
paimon-web-server/pom.xml:
##########
@@ -214,6 +220,7 @@ under the License.
<configuration>
<classesDirectory>target/classes/</classesDirectory>
<excludes>
+ <!--注意这玩意默认从编译结果目录开始算目录结构-->
Review Comment:
This can be changed to English
##########
paimon-web-server/src/main/resources/db/ddl-h2.sql:
##########
@@ -0,0 +1,50 @@
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+CREATE TABLE if not exists `user`
+(
+ `id` int(11) NOT NULL PRIMARY KEY AUTO_INCREMENT COMMENT
'ID',
+ `username` varchar(50) NOT NULL COMMENT 'username',
+ `password` varchar(50) NULL DEFAULT NULL COMMENT 'password',
+ `nickname` varchar(50) NULL DEFAULT NULL COMMENT 'nickname',
+ `user_type` int NOT NULL DEFAULT 0 COMMENT 'login type
(0:LOCAL,1:LDAP)',
+ `url` varchar(100) NULL DEFAULT NULL COMMENT 'avatar url',
+ `mobile` varchar(20) NULL DEFAULT NULL COMMENT 'mobile phone',
+ `email` varchar(100) NULL DEFAULT NULL COMMENT 'email',
+ `enabled` tinyint(1) NOT NULL DEFAULT 1 COMMENT 'is enable',
+ `is_delete` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'is delete',
+ `create_time` datetime(0) NULL DEFAULT CURRENT_TIMESTAMP COMMENT
'create time',
+ `update_time` datetime(0) NULL DEFAULT CURRENT_TIMESTAMP COMMENT
'update time'
+) ENGINE = InnoDB;
Review Comment:
ENGINE = InnoDB;
##########
paimon-web-server/src/main/resources/db/ddl-h2.sql:
##########
@@ -0,0 +1,50 @@
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+
+CREATE TABLE if not exists `user`
+(
+ `id` int(11) NOT NULL PRIMARY KEY AUTO_INCREMENT COMMENT
'ID',
+ `username` varchar(50) NOT NULL COMMENT 'username',
+ `password` varchar(50) NULL DEFAULT NULL COMMENT 'password',
+ `nickname` varchar(50) NULL DEFAULT NULL COMMENT 'nickname',
+ `user_type` int NOT NULL DEFAULT 0 COMMENT 'login type
(0:LOCAL,1:LDAP)',
+ `url` varchar(100) NULL DEFAULT NULL COMMENT 'avatar url',
+ `mobile` varchar(20) NULL DEFAULT NULL COMMENT 'mobile phone',
+ `email` varchar(100) NULL DEFAULT NULL COMMENT 'email',
+ `enabled` tinyint(1) NOT NULL DEFAULT 1 COMMENT 'is enable',
+ `is_delete` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'is delete',
+ `create_time` datetime(0) NULL DEFAULT CURRENT_TIMESTAMP COMMENT
'create time',
+ `update_time` datetime(0) NULL DEFAULT CURRENT_TIMESTAMP COMMENT
'update time'
+) ENGINE = InnoDB;
Review Comment:
does h2 support this ddl?
##########
paimon-web-server/pom.xml:
##########
@@ -214,6 +220,7 @@ under the License.
<configuration>
<classesDirectory>target/classes/</classesDirectory>
<excludes>
+ <!--注意这玩意默认从编译结果目录开始算目录结构-->
<exclude>/application*.yml</exclude>
<exclude>/mybatis*.xml</exclude>
<exclude>/DinkyFlinkDockerfile</exclude>
Review Comment:
Can help to modify here，DinkyFlinkDockerfile？
##########
paimon-web-server/pom.xml:
##########
@@ -214,6 +220,7 @@ under the License.
<configuration>
<classesDirectory>target/classes/</classesDirectory>
<excludes>
+ <!--注意这玩意默认从编译结果目录开始算目录结构-->
<exclude>/application*.yml</exclude>
<exclude>/mybatis*.xml</exclude>
<exclude>/DinkyFlinkDockerfile</exclude>
Review Comment:
Can help to modify here，DinkyFlinkDockerfile？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
