zhuangchong commented on code in PR #1676:
URL: https://github.com/apache/incubator-paimon/pull/1676#discussion_r1277260110
##########
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkCatalog.java:
##########
@@ -315,48 +320,77 @@ public boolean dropTable(Identifier ident) {
}
}
- private SchemaChange toSchemaChange(TableChange change) {
+ private List<SchemaChange> toSchemaChange(TableChange change) {
+ final List<SchemaChange> schemaChanges = new ArrayList<>();
if (change instanceof TableChange.SetProperty) {
TableChange.SetProperty set = (TableChange.SetProperty) change;
validateAlterProperty(set.property());
- return SchemaChange.setOption(set.property(), set.value());
+ schemaChanges.add(SchemaChange.setOption(set.property(),
set.value()));
+ return schemaChanges;
} else if (change instanceof TableChange.RemoveProperty) {
TableChange.RemoveProperty remove = (TableChange.RemoveProperty)
change;
validateAlterProperty(remove.property());
- return SchemaChange.removeOption(remove.property());
+ schemaChanges.add(SchemaChange.removeOption(remove.property()));
+ return schemaChanges;
} else if (change instanceof TableChange.AddColumn) {
TableChange.AddColumn add = (TableChange.AddColumn) change;
validateAlterNestedField(add.fieldNames());
SchemaChange.Move move = getMove(add.position(), add.fieldNames());
- return SchemaChange.addColumn(
- add.fieldNames()[0],
- toPaimonType(add.dataType()).copy(add.isNullable()),
- add.comment(),
- move);
+ schemaChanges.add(
+ SchemaChange.addColumn(
+ add.fieldNames()[0],
+
toPaimonType(add.dataType()).copy(add.isNullable()),
+ add.comment(),
+ move));
+ if (Objects.nonNull(add.defaultValue())) {
Review Comment:
`UpdateColumnDefaultValue` also exists in spark 3.4, how should I deal with
this situation？
is to close this PR Or is it written under the spark3.4 module?
##########
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkCatalog.java:
##########
@@ -315,48 +320,77 @@ public boolean dropTable(Identifier ident) {
}
}
- private SchemaChange toSchemaChange(TableChange change) {
+ private List<SchemaChange> toSchemaChange(TableChange change) {
+ final List<SchemaChange> schemaChanges = new ArrayList<>();
if (change instanceof TableChange.SetProperty) {
TableChange.SetProperty set = (TableChange.SetProperty) change;
validateAlterProperty(set.property());
- return SchemaChange.setOption(set.property(), set.value());
+ schemaChanges.add(SchemaChange.setOption(set.property(),
set.value()));
+ return schemaChanges;
} else if (change instanceof TableChange.RemoveProperty) {
TableChange.RemoveProperty remove = (TableChange.RemoveProperty)
change;
validateAlterProperty(remove.property());
- return SchemaChange.removeOption(remove.property());
+ schemaChanges.add(SchemaChange.removeOption(remove.property()));
+ return schemaChanges;
} else if (change instanceof TableChange.AddColumn) {
TableChange.AddColumn add = (TableChange.AddColumn) change;
validateAlterNestedField(add.fieldNames());
SchemaChange.Move move = getMove(add.position(), add.fieldNames());
- return SchemaChange.addColumn(
- add.fieldNames()[0],
- toPaimonType(add.dataType()).copy(add.isNullable()),
- add.comment(),
- move);
+ schemaChanges.add(
+ SchemaChange.addColumn(
+ add.fieldNames()[0],
+
toPaimonType(add.dataType()).copy(add.isNullable()),
+ add.comment(),
+ move));
+ if (Objects.nonNull(add.defaultValue())) {
Review Comment:
`UpdateColumnDefaultValue` also exists in spark 3.4, how should I deal with
this situation？
is to close this PR Or is it written under the spark3.4 module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
