Zouxxyy commented on code in PR #1756:
URL: https://github.com/apache/incubator-paimon/pull/1756#discussion_r1287862568
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonAnalysis.scala:
##########
@@ -28,6 +32,21 @@ class PaimonAnalysis(session: SparkSession) extends
Rule[LogicalPlan] {
case func: PaimonTableValueFunction if func.args.forall(_.resolved) =>
PaimonTableValuedFunctions.resolvePaimonTableValuedFunction(session,
func)
+ case o @ OverwritePartitionsDynamicPaimon(r, d) if o.resolved =>
+ PaimonDynamicPartitionOverwriteCommand(r, d, o.query, o.writeOptions,
o.isByName)
}
+}
+object OverwritePartitionsDynamicPaimon {
+ def unapply(o: OverwritePartitionsDynamic): Option[(DataSourceV2Relation,
FileStoreTable)] = {
+ if (o.query.resolved) {
+ o.table match {
+ case r: DataSourceV2Relation if r.table.isInstanceOf[SparkTable] =>
Review Comment:
@YannByron The constructor of `DataSourceV2Relation` may change, the current
code is more conducive to multi-version compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]