JingsongLi commented on code in PR #1825:
URL: https://github.com/apache/incubator-paimon/pull/1825#discussion_r1294726365
##########
paimon-core/src/main/java/org/apache/paimon/io/KeyValueFileWriterFactory.java:
##########
@@ -164,11 +165,14 @@ private Builder(
public KeyValueFileWriterFactory build(
BinaryRow partition, int bucket, CoreOptions options) {
RowType fileRowType = KeyValue.schema(keyType, valueType);
+ RowType storageRowType =
RowTypeUtils.toStorageRowType(fileRowType);
Review Comment:
Here we need an option, by default, we can use old style row type. Because
we need to be as compatible with old readers as possible.
Then wait for 1-2 versions, and switch to the default mode to thin mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
