JingsongLi commented on code in PR #1833:
URL: https://github.com/apache/incubator-paimon/pull/1833#discussion_r1297175939
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -358,9 +358,28 @@ public void renameTable(Identifier fromTable, Identifier
toTable, boolean ignore
try {
checkIdentifierUpperCase(toTable);
+
+ // Rename the file system's table directory. Maintain consistency
between tables in the
+ // file system and tables in the Hive Metastore.
+ Path fromPath = getDataTableLocation(fromTable);
+ Path toPath = getDataTableLocation(toTable);
+ try {
+ fileIO.rename(fromPath, toPath);
Review Comment:
The birth of bugs is because the codes did not perform a minimum protection
action, which I suggested in PR.
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -358,9 +358,28 @@ public void renameTable(Identifier fromTable, Identifier
toTable, boolean ignore
try {
checkIdentifierUpperCase(toTable);
+
+ // Rename the file system's table directory. Maintain consistency
between tables in the
+ // file system and tables in the Hive Metastore.
+ Path fromPath = getDataTableLocation(fromTable);
+ Path toPath = getDataTableLocation(toTable);
+ try {
+ fileIO.rename(fromPath, toPath);
Review Comment:
The birth of this bug is because the codes did not perform a minimum
protection action, which I suggested in PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
