liming30 commented on code in PR #1869:
URL: https://github.com/apache/incubator-paimon/pull/1869#discussion_r1301781996
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/AutoTagForSavepointCommitterOperator.java:
##########
@@ -127,8 +127,10 @@ public OperatorSnapshotFutures snapshotState(
@Override
public void notifyCheckpointComplete(long checkpointId) throws Exception {
commitOperator.notifyCheckpointComplete(checkpointId);
- if (identifiersForTags.remove(checkpointId)) {
- createTagForIdentifiers(Collections.singletonList(checkpointId));
+ // savepoint do not trigger notifyCheckpointComplete method
+ long savepointId = checkpointId - 1;
Review Comment:
We may need to make tags for all previous successful savepoints that are
less than `checkpointId`, instead of just `checkpointId - 1 `(considering the
case where multiple savepoints are triggered consecutively).
This feature may work fine under `stop-with-savepoint`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
