hehuiyuan commented on PR #1839: URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1707834178
Hi @JingsongLi , the test class > Hi @JingsongLi , > > ```java > Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.319 s <<< FAILURE! - in org.apache.paimon.docs.configuration.ConfigOptionsDocsCompletenessITCase > Error: org.apache.paimon.docs.configuration.ConfigOptionsDocsCompletenessITCase.testCompleteness Time elapsed: 0.298 s <<< FAILURE! > java.lang.AssertionError: > Documentation is outdated, please regenerate it according to the instructions in paimon-docs/README.md. > Problems: > Documentation of hadoop-conf-dir in HiveCatalogOptions is outdated. Expected: default=((none)) description=(File directory of the core-site.xml、hdfs-site.xml、yarn-site.xml、mapred-site.xml. Currently, only local file system paths are supported. > If not configured, try to load from 'HADOOP_CONF_DIR' or 'HADOOP_HOME' system environment. > Configure Priority: 1.from 'hadoop-conf-dir' 2.from HADOOP_CONF_DIR 3.from HADOOP_HOME/conf 4.HADOOP_HOME/etc/hadoop.). > Documentation of hive-conf-dir in HiveCatalogOptions is outdated. Expected: default=((none)) description=(File directory of the hive-site.xml , used to create HiveMetastoreClient and security authentication, such as Kerberos, LDAP, Ranger and so on. > If not configured, try to load from 'HIVE_CONF_DIR' env.). > Documented option hadoop-conf-dir does not exist. > Documented option hive-conf-dir does not exist. > ``` > > The error has ambiguity, when both document and ConfigOption exist, but the description or default value are not same. > > ``` > Documented option hadoop-conf-dir does not exist. > Documented option hive-conf-dir does not exist. > ``` > > Is it feasible to add the following code? > > ConfigOptionsDocsCompletenessITCase.compareDocumentedAndExistingOptions  > > Test result:  Hi @JingsongLi , does this need further improment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
