pongandnoon commented on code in PR #2010:
URL: https://github.com/apache/incubator-paimon/pull/2010#discussion_r1325632297
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -214,7 +214,10 @@ private Factory(Options options, RowType rowType) {
"Field %s is
defined repeatedly by multiple groups: %s",
fieldNames.get(field), k));
}
- fieldSequences.put(field, sequenceGen);
+
+ if (field >= 0) {
Review Comment:
If we just define a sequenceGroup with fields which not in table schema,
It don’t report any Exception, just ignore.Because it don't affect write .So I
think sequenceGroup is repeat defined with fields which not in table schema
should't report Exception,it can alse write.
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -214,7 +214,10 @@ private Factory(Options options, RowType rowType) {
"Field %s is
defined repeatedly by multiple groups: %s",
fieldNames.get(field), k));
}
- fieldSequences.put(field, sequenceGen);
+
+ if (field >= 0) {
Review Comment:
If we just define a sequenceGroup with fields which not in table schema,
It don’t report any Exception, just ignore.Because it don't affect write .So I
think sequenceGroup is repeat defined with fields which not in table schema
should't report Exception,it can alse write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
