SteNicholas commented on code in PR #48: URL: https://github.com/apache/incubator-paimon-webui/pull/48#discussion_r1358035333
########## paimon-web-ui-new/auto-imports.d.ts: ########## @@ -1,20 +1,3 @@ -/* Licensed to the Apache Software Foundation (ASF) under one -or more contributor license agreements. See the NOTICE file -distributed with this work for additional information -regarding copyright ownership. The ASF licenses this file -to you under the Apache License, Version 2.0 (the -"License"); you may not use this file except in compliance -with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, -software distributed under the License is distributed on an -"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -KIND, either express or implied. See the License for the -specific language governing permissions and limitations -under the License. */ - Review Comment: Why update this file? Pls revert. ########## paimon-web-server/src/main/resources/application-dev-mysql.yml: ########## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +spring: + datasource: + url: jdbc:mysql://${MYSQL_ADDR:43.143.237.199:3306}/${MYSQL_DATABASE:paimon}?useUnicode=true&characterEncoding=UTF-8&autoReconnect=true&useSSL=false&zeroDateTimeBehavior=convertToNull&serverTimezone=Asia/Shanghai&allowPublicKeyRetrieval=true Review Comment: @s7monk, pls do not expose the IP in any files. ########## paimon-web-server/src/main/resources/i18n/messages.properties: ########## @@ -35,7 +35,16 @@ menu.name.exist=This menu name is exist:{0} menu.path.invalid=This menu path is invalid:{0} catalog.name.exist=This catalog name {0} is exist catalog.create.error=An exception is returned when calling the Paimon API to create a Catalog. +catalog.remove.error=An exception is returned when calling the Paimon API to remove a Catalog. Review Comment: ```suggestion catalog.remove.error=Exception calling Paimon Catalog API to remove a Catalog. ``` The below could update with this suggestion. ########## pom.xml: ########## @@ -358,6 +358,10 @@ under the License. <!-- artifacts created during release process --> <exclude>release/**</exclude> <exclude>paimon-web-ui/node_modules/**</exclude> + <exclude>/node_modules/**</exclude> Review Comment: Why update this file? Pls revert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
