FangYongs commented on code in PR #2123:
URL: https://github.com/apache/incubator-paimon/pull/2123#discussion_r1360421973


##########
paimon-core/src/main/java/org/apache/paimon/table/source/AbstractInnerTableScan.java:
##########
@@ -187,6 +187,11 @@ protected StartingScanner createStartingScanner(boolean 
isStreaming) {
         }
     }
 
+    @Override
+    public void close() {
+        // do nothing yet

Review Comment:
   All the `close()` methods in `AbstractInnerTableScan` and 
`ReadOnceTableScan` are empty, why do we need it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to