JingsongLi commented on code in PR #2167:
URL: https://github.com/apache/incubator-paimon/pull/2167#discussion_r1371248448
##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -113,6 +118,16 @@ public void createDatabase(String name, boolean
ignoreIfExists)
createDatabaseImpl(name);
}
+ @Override
+ public void dropPartition(Identifier identifier, Map<String, String>
partitionSpec)
+ throws TableNotExistException, PartitionNotExistException {
+ Table table = getTable(identifier);
+ AbstractFileStoreTable fileStoreTable = (AbstractFileStoreTable) table;
+ FileStoreCommit commit =
fileStoreTable.store().newCommit(UUID.randomUUID().toString());
+ commit.dropPartitions(
Review Comment:
It looks that we should delete partitions of metastore in `FileStoreCommit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
