JingsongLi commented on code in PR #2180:
URL: https://github.com/apache/incubator-paimon/pull/2180#discussion_r1374056761
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -87,6 +88,16 @@ public static void validateTableSchema(TableSchema schema) {
"Can not set %s on table without primary keys,
please define primary keys.",
CHANGELOG_PRODUCER.key()));
}
+ if (options.streamingReadOverwrite()
+ && (changelogProducer == ChangelogProducer.FULL_COMPACTION
+ || changelogProducer == ChangelogProducer.LOOKUP)) {
+ throw new UnsupportedOperationException(
+ String.format(
+ "Cannot set %s to true when changelog producer is
%s or %s.",
Review Comment:
Add why, and add a test in `CatalogTableITCase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]