SteNicholas commented on code in PR #54: URL: https://github.com/apache/incubator-paimon-webui/pull/54#discussion_r1374384100
########## paimon-web-server/src/main/java/org/apache/paimon/web/server/data/dto/QueryMetadataDTO.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.web.server.data.dto; + +import lombok.Data; + +/** DTO of query metadata is used for getting table metadata. */ +@Data +public class QueryMetadataDTO { + private String catalogName; Review Comment: Adds the new line among fields. ########## paimon-web-server/src/main/java/org/apache/paimon/web/server/data/vo/DataFileVO.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.web.server.data.vo; + +/** VO of metadata data file. */ +public class DataFileVO { + + private final String partition; + private final long bucket; + private final String filePath; + private final String fileFormat; + + public DataFileVO(String partition, long bucket, String filePath, String fileFormat) { + this.partition = partition; + this.bucket = bucket; + this.filePath = filePath; + this.fileFormat = fileFormat; + } + + public String getPartition() { + return partition; + } + + public long getBucket() { + return bucket; + } + + public String getFilePath() { + return filePath; + } + + public String getFileFormat() { + return fileFormat; + } + + public static Builder builder() { Review Comment: Could all VOs add the setter instead of builder? ########## paimon-web-server/src/main/java/org/apache/paimon/web/server/data/model/MetadataFieldsModel.java: ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.web.server.data.model; + +import lombok.Data; + +/** Model of metadata fields. */ +@Data +public class MetadataFieldsModel { + private int id; Review Comment: Ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
