JingsongLi commented on code in PR #2183:
URL: https://github.com/apache/incubator-paimon/pull/2183#discussion_r1377084963
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/commands/WriteIntoPaimonTable.scala:
##########
@@ -132,7 +134,12 @@ case class WriteIntoPaimonTable(
row =>
val bucket = row.getInt(bucketColIdx)
val bucketColDropped = originFromRow(toRow(row))
- write.write(new DynamicBucketRow(new SparkRow(rowType,
bucketColDropped), bucket))
+ val sparkRow = new SparkRow(rowType, bucketColDropped)
+ if (row.schema.fieldNames.contains(ROW_KIND_COL)) {
Review Comment:
Can we create a `RemoveRowKindIterator` here?
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/commands/WriteIntoPaimonTable.scala:
##########
@@ -132,7 +134,12 @@ case class WriteIntoPaimonTable(
row =>
val bucket = row.getInt(bucketColIdx)
val bucketColDropped = originFromRow(toRow(row))
- write.write(new DynamicBucketRow(new SparkRow(rowType,
bucketColDropped), bucket))
+ val sparkRow = new SparkRow(rowType, bucketColDropped)
+ if (row.schema.fieldNames.contains(ROW_KIND_COL)) {
Review Comment:
This if should be out of the loop, it has some performance impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
