schnappi17 commented on code in PR #2224:
URL: https://github.com/apache/incubator-paimon/pull/2224#discussion_r1384457917
##########
paimon-core/src/main/java/org/apache/paimon/table/sink/TableWriteImpl.java:
##########
@@ -146,6 +156,18 @@ public void compact(BinaryRow partition, int bucket,
boolean fullCompaction) thr
write.compact(partition, bucket, fullCompaction);
}
+ @Override
+ public TableWrite withMetricRegistry(MetricRegistry registry, BinaryRow
partition, int bucket) {
+ write.withMetrics(
+ new CompactionMetrics(registry, tableName,
getPartitionString(partition), bucket));
+ return this;
+ }
Review Comment:
Yes, I've notice that when developing the code for bridging to flink metrics
system, I'll update this asap. Thank you for reminding me~ @tsreaper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
