humengyu2012 commented on code in PR #2315:
URL: https://github.com/apache/incubator-paimon/pull/2315#discussion_r1393989670


##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -161,6 +161,18 @@ public Optional<MetastoreClient.Factory> 
metastoreClientFactory(Identifier ident
         }
     }
 
+    @Override
+    public Path getDataTableLocation(Identifier identifier) {
+        try {
+            return new Path(
+                    client.getTable(identifier.getDatabaseName(), 
identifier.getObjectName())
+                            .getSd()
+                            .getLocation());
+        } catch (TException e) {

Review Comment:
   Regarding HiveCatalog, I have a question: should we fallback to the parent 
implemets, or should we adhere to the Hive specification and create tables 
under the database path? @JingsongLi 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to