YannByron commented on code in PR #2361:
URL: https://github.com/apache/incubator-paimon/pull/2361#discussion_r1400565150
##########
paimon-core/src/main/java/org/apache/paimon/table/source/DataSplit.java:
##########
@@ -89,6 +92,16 @@ public long rowCount() {
return rowCount;
}
+ @Override
+ public boolean needsMerging() {
+ return rawFiles.isEmpty();
Review Comment:
IMO, thinking about supporting chang-log tables for SR or Spark native
engine, `needsMerge` should not depend on whether the list of `rawFile` is
empty. We can depend on whether table is a change-log table or an append-on
table for now. Further, even this's a change-log table, It should be judged by
whether these documents overlap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
