zhuangchong commented on code in PR #2345:
URL: https://github.com/apache/incubator-paimon/pull/2345#discussion_r1410042056
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/pulsar/PulsarActionUtils.java:
##########
@@ -324,8 +324,7 @@ static DataFormat getDataFormat(Configuration pulsarConfig)
{
/** Referenced to {@link PulsarPartitionSplitReader#createPulsarConsumer}.
*/
static MessageQueueSchemaUtils.ConsumerWrapper createPulsarConsumer(
Configuration pulsarConfig, String topic) throws
PulsarClientException {
- SourceConfiguration pulsarSourceConfiguration =
- toSourceConfiguration(preprocessPulsarConfig(pulsarConfig));
Review Comment:
I found that the `preprocessPulsarConfig` method will be executed first in
the `toSourceConfiguration` method, so preprocessPulsarConfig is deleted here.
```java
static SourceConfiguration toSourceConfiguration(Configuration
rawConfig) {
return new SourceConfiguration(preprocessPulsarConfig(rawConfig));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
