Xiangakun commented on PR #2441:
URL:
https://github.com/apache/incubator-paimon/pull/2441#issuecomment-1838824017
> @Xiangakun
>
> > since the writeBuilder in bucketMode match { } is not the same with the
one after collect
>
> Can you explain it in more detail?
Sorry, you're correct, I made a mistake ~
> > And your test case does not cover the real compact action, it will not
do a compaction since only one file in each bucket
>
> In fact, the trigger of this bug is that when inserting overwrite
partition pk table, restoreFiles + new file can reach
`num-sorted-run.compaction-trigger` (no need compaction to be done before), my
test can just cover it.
Yes, I agree with you, and I think it's necessary to test the compact action
along with insert overwrite, and make sure , the data is still correct after
compaction, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
