zhangmo8 commented on code in PR #99:
URL:
https://github.com/apache/incubator-paimon-webui/pull/99#discussion_r1426211633
##########
paimon-web-ui-new/src/views/cdc/components/list/index.tsx:
##########
@@ -15,229 +15,17 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License. */
+import { NDataTable, NPagination, NSpace } from 'naive-ui';
Review Comment:
remove import
##########
paimon-web-ui-new/src/views/cdc/components/list/index.tsx:
##########
@@ -247,12 +35,24 @@ export default defineComponent({
render() {
return (
<div class={styles['list-page']}>
- <n-data-table
- columns={this.columns}
- data={this.data}
- pagination={this.pagination}
- bordered={false}
- />
+ <NSpace vertical>
+ <NDataTable
+ columns={this.columns}
+ data={this.data}
+ />
+ <NSpace justify='center'>
+ <NPagination
+ v-model:page={this.pagination.page}
+ v-model:page-size={this.pagination.pageSize}
+ item-count={this.pagination.count}
+ show-size-picker
+ page-sizes={this.pagination.pageSizes}
+ show-quick-jumper
+ onUpdatePage={this.pagination.onChange}
+ onUpdatePageSize={this.pagination.onUpdatePageSize}
+ />
+ </NSpace>
+ </NSpace>
Review Comment:
These components can be automatically imported by `n-space` and do not need
to be imported by yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
