SteNicholas commented on code in PR #107: URL: https://github.com/apache/incubator-paimon-webui/pull/107#discussion_r1438071048
########## paimon-web-flink/src/main/java/org/apache/paimon/web/flink/executor/FlinkExecutor.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.web.flink.executor; + +import org.apache.paimon.web.common.executor.Executor; +import org.apache.paimon.web.common.result.FetchResultParams; +import org.apache.paimon.web.common.result.SubmitResult; +import org.apache.paimon.web.flink.exception.SqlExecutionException; +import org.apache.paimon.web.flink.operation.FlinkSqlOperationType; +import org.apache.paimon.web.flink.parser.StatementParser; +import org.apache.paimon.web.flink.utils.CollectResultUtil; +import org.apache.paimon.web.flink.utils.FormatSqlExceptionUtil; + +import org.apache.commons.collections.CollectionUtils; +import org.apache.flink.core.execution.JobClient; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.table.api.StatementSet; +import org.apache.flink.table.api.TableEnvironment; +import org.apache.flink.table.api.TableResult; + +import java.util.ArrayList; +import java.util.List; +import java.util.Optional; + +/** The flink implementation of the {@link Executor}. */ +public class FlinkExecutor implements Executor { + + private static final String EXECUTE_SUCCESS = "OK"; + private final StreamExecutionEnvironment env; + private final TableEnvironment tableEnv; + + public FlinkExecutor(StreamExecutionEnvironment env, TableEnvironment tableEnv) { + this.env = env; + this.tableEnv = tableEnv; + } + + @Override + public SubmitResult executeSql(String multiStatement) throws SqlExecutionException { + List<String> insertStatements = new ArrayList<>(); + String[] statements = StatementParser.parse(multiStatement); + for (String statement : statements) { + FlinkSqlOperationType operationType = FlinkSqlOperationType.getOperationType(statement); + switch (operationType.getCategory()) { + case DQL: + if (insertStatements.isEmpty()) { + return executeQueryStatement(statement); + } + break; + case DML: + if (operationType.getType().equals(FlinkSqlOperationType.INSERT.getType())) { + insertStatements.add(statement); + } else if (insertStatements.isEmpty()) { + return executeDmlStatement(statement); + } + break; + default: + executeStatementWithoutResult(statement); + break; + } + } + return executeInsertStatements(insertStatements); Review Comment: @s7monk, IMO, this could merge into DML branch, no need to distiguish here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
