FangYongs commented on code in PR #2608:
URL: https://github.com/apache/incubator-paimon/pull/2608#discussion_r1441760767


##########
paimon-core/src/main/java/org/apache/paimon/utils/SnapshotManager.java:
##########
@@ -50,7 +50,7 @@ public class SnapshotManager implements Serializable {
 
     private static final long serialVersionUID = 1L;
 
-    private static final String SNAPSHOT_PREFIX = "snapshot-";
+    protected static final String SNAPSHOT_PREFIX = "snapshot-";

Review Comment:
   The internal prefix should not be accessed by `BranchManager`



##########
paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java:
##########
@@ -46,7 +46,7 @@ public class TagManager {
 
     private static final Logger LOG = 
LoggerFactory.getLogger(TagManager.class);
 
-    private static final String TAG_PREFIX = "tag-";
+    protected static final String TAG_PREFIX = "tag-";

Review Comment:
   As above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to