zhoulii commented on code in PR #155:
URL:
https://github.com/apache/incubator-paimon-webui/pull/155#discussion_r1464805108
##########
paimon-web-server/src/main/java/org/apache/paimon/web/server/service/impl/MetadataServiceImpl.java:
##########
@@ -171,6 +172,26 @@ public List<DataFileVO> getDataFile(MetadataDTO dto) {
return result;
}
+ @Override
+ public List<OptionVO> getOption(MetadataDTO dto) {
+ initEnvironment(dto, MetadataConstant.OPTIONS);
+
+ List<OptionVO> result = new LinkedList<>();
+
+ try {
+ reader.forEachRemaining(
+ internalRow -> {
+ OptionVO optionVo = new OptionVO();
+ optionVo.setKey(internalRow.getString(0).toString());
Review Comment:
Thanks for the review @SteNicholas . Maybe I did not think it through
thoroughly, I cannot anticipate under what circumstances the $options table
would have a null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
