zhuangchong commented on code in PR #2782:
URL: https://github.com/apache/incubator-paimon/pull/2782#discussion_r1464669514
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSyncDatabaseActionFactory.java:
##########
@@ -70,7 +70,7 @@ public Optional<Action> create(MultipleParameterToolAdapter
params) {
.excludingTables(params.get(EXCLUDING_TABLES))
.withMode(MultiTablesSinkMode.fromString(params.get(MODE)));
if (params.has(METADATA_COLUMN)) {
-
action.withMetadataColumns(Arrays.asList(params.get(METADATA_COLUMN).split(",")));
+ action.withMetadataColumns(new
ArrayList<>(params.getMultiParameter(METADATA_COLUMN)));
Review Comment:
We need the METADATA_COLUMN parameter to be compatible with history and
unified.
The documentation of mysql database cdc also needs to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
