schnappi17 commented on code in PR #2748:
URL: https://github.com/apache/incubator-paimon/pull/2748#discussion_r1474002233
##########
paimon-core/src/main/java/org/apache/paimon/utils/SnapshotManager.java:
##########
@@ -352,13 +377,16 @@ public Snapshot
traversalSnapshotsFromLatestSafely(Filter<Snapshot> checker) {
return null;
}
- private @Nullable Long findLatest() throws IOException {
- Path snapshotDir = snapshotDirectory();
+ private @Nullable Long findLatest(String branchName) throws IOException {
+ Path snapshotDir =
+ branchName.equals(DEFAULT_MAIN_BRANCH)
+ ? snapshotDirectory()
Review Comment:
This piece of code appeared many times, could you provide a method to
express this directory logic simply?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
