Aitozi commented on code in PR #2942:
URL: https://github.com/apache/incubator-paimon/pull/2942#discussion_r1513709847
##########
paimon-core/src/main/java/org/apache/paimon/table/ExpireSnapshotsImpl.java:
##########
@@ -186,17 +186,6 @@ public int expireUntil(long earliestId, long
endExclusiveId) {
snapshotDeletion.cleanUnusedDataFiles(snapshot, skipper);
}
- // delete changelog files
- for (long id = beginInclusiveId; id < endExclusiveId; id++) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Ready to delete changelog files from snapshot #" +
id);
- }
- Snapshot snapshot = snapshotManager.snapshot(id);
- if (snapshot.changelogManifestList() != null) {
Review Comment:
Agree, will give a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
