JingsongLi commented on code in PR #3298:
URL: https://github.com/apache/paimon/pull/3298#discussion_r1591002153
##########
paimon-common/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -1157,7 +1161,7 @@ public static Path path(Options options) {
return new Path(options.get(PATH));
}
- public FileFormatType formatType() {
+ public String formatType() {
return options.get(FILE_FORMAT);
Review Comment:
I think we need to toLowerCase here. Consider:
```
Options options = new Options();
options.setString(CoreOptions.FILE_FORMAT.key(), "AVRO");
System.out.println(options.get(CoreOptions.FILE_FORMAT));
```
Upper case works fine, the change should be compatible to upper case usage.
You can add test in `FileFormatTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
