hzjhjjyy commented on code in PR #3299:
URL: https://github.com/apache/paimon/pull/3299#discussion_r1593713490


##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -441,20 +439,6 @@ default Long generateNullable(InternalRow row, int i) {
 
         private static class SequenceGeneratorVisitor extends 
DataTypeDefaultVisitor<Generator> {
 
-            @Override

Review Comment:
   The doc doesn't mention support for STRING, so I removed it. Otherwise, 
using STRING might throw errors.
   > For fields.<field-name>.sequence-group, valid comparative data types 
include: DECIMAL, TINYINT, SMALLINT, INTEGER, BIGINT, FLOAT, DOUBLE, DATE, 
TIME, TIMESTAMP, and TIMESTAMP_LTZ.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to