MOBIN-F commented on code in PR #3311:
URL: https://github.com/apache/paimon/pull/3311#discussion_r1605363810
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcActionCommonUtils.java:
##########
@@ -83,8 +83,10 @@ public static boolean schemaCompatible(
for (DataField field : sourceTableFields) {
int idx = paimonSchema.fieldNames().indexOf(field.name());
if (idx < 0) {
- LOG.info("Cannot find field '{}' in Paimon table.",
field.name());
- return false;
+ LOG.info(
+ "New fields '{}' found in source table, will be
synchronized to Paimon table.",
+ field.name());
+ return true;
}
Review Comment:
When idx is less than 0, it means that a new field has been added. Should
schemaEvolution be performed? what you think?
@yuzelin @JingsongLi @zhuangchong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
