liming30 commented on code in PR #3297:
URL: https://github.com/apache/paimon/pull/3297#discussion_r1609221599
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/FullCacheLookupTable.java:
##########
@@ -189,6 +275,9 @@ public Predicate projectedPredicate() {
@Override
public void close() throws IOException {
stateFactory.close();
+ if (refreshExecutor != null) {
+ refreshExecutor.shutdown();
Review Comment:
This prefer to be placed in a `try-finally` block to avoid thread leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
