YannByron commented on code in PR #3368:
URL: https://github.com/apache/paimon/pull/3368#discussion_r1609773886
##########
paimon-core/src/main/java/org/apache/paimon/deletionvectors/DeletionVectorsIndexFile.java:
##########
@@ -48,18 +50,20 @@ public DeletionVectorsIndexFile(FileIO fileIO, PathFactory
pathFactory) {
/**
* Reads all deletion vectors from a specified file.
*
- * @param fileName The name of the file from which to read the deletion
vectors.
- * @param deletionVectorRanges A map where the key represents which file
the DeletionVector
- * belongs to and the value is a Pair object specifying the range
(start position and size)
- * within the file where the deletion vector data is located.
* @return A map where the key represents which file the DeletionVector
belongs to, and the
* value is the corresponding DeletionVector object.
* @throws UncheckedIOException If an I/O error occurs while reading from
the file.
*/
- public Map<String, DeletionVector> readAllDeletionVectors(
- String fileName, LinkedHashMap<String, Pair<Integer, Integer>>
deletionVectorRanges) {
+ public Map<String, DeletionVector> readAllDeletionVectors(IndexFileMeta
fileMeta) {
+ LinkedHashMap<String, Pair<Integer, Integer>> deletionVectorRanges =
+ fileMeta.deletionVectorsRanges();
+ if (deletionVectorRanges == null || deletionVectorRanges.isEmpty()) {
Review Comment:
yep, this IndexFileMeta must be Deletion_Vector Index, and `ranges` is not
empty. Can remove this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
