WencongLiu commented on code in PR #3384: URL: https://github.com/apache/paimon/pull/3384#discussion_r1616626134
########## paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sorter/TableSortInfo.java: ########## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.flink.sorter; + +import org.apache.paimon.flink.FlinkConnectorOptions; + +import java.util.Collections; +import java.util.List; + +import static org.apache.flink.shaded.guava31.com.google.common.base.Preconditions.checkArgument; + +/** + * {@link TableSortInfo} is used to indicate the configuration details for table data sorting. This + * includes information about which columns to sort by, the sorting strategy (e.g., order, Z-order), + * whether to sort within each cluster, and sample sizes for local and global sample nodes. + */ +public class TableSortInfo { + + private final List<String> sortColumns; + + private final String sortStrategy; + + private final boolean sortInCluster; + + private final int rangeNumber; + + private final int sinkParallelism; + + private final int localSampleSize; + + private final int globalSampleSize; + + private TableSortInfo( + List<String> sortColumns, + String sortStrategy, + boolean sortInCluster, + int rangeNumber, + int sinkParallelism, + int localSampleSize, + int globalSampleSize) { + checkArgument(!sortColumns.isEmpty(), "Sort columns cannot be empty"); Review Comment: Yes, placing all the check statements in the build is already sufficient. The changes have been made as requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
