JingsongLi commented on code in PR #3772:
URL: https://github.com/apache/paimon/pull/3772#discussion_r1682024276
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldAggregator.java:
##########
@@ -172,6 +172,10 @@ private static FieldAggregator createFieldNestedUpdateAgg(
public abstract Object agg(Object accumulator, Object inputField);
+ public Object aggReversed(Object inputField, Object accumulator) {
+ return agg(inputField, accumulator);
Review Comment:
```
public Object aggReversed(Object accumulator, Object inputField) {
return agg(inputField, accumulator);
}
```
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/aggregate/FieldCollectAgg.java:
##########
@@ -87,6 +87,12 @@ String name() {
return NAME;
}
+ @Override
+ public Object aggReversed(Object inputField, Object accumulator) {
+ // reverse back for this agg
Review Comment:
add comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
