BsoBird commented on code in PR #3805:
URL: https://github.com/apache/paimon/pull/3805#discussion_r1689058409


##########
paimon-core/src/test/java/org/apache/paimon/TestFileStore.java:
##########
@@ -363,7 +363,9 @@ public List<Snapshot> commitDataImpl(
 
         List<Snapshot> snapshots = new ArrayList<>();
         for (long id = snapshotIdBeforeCommit + 1; id <= 
snapshotIdAfterCommit; id++) {
-            snapshots.add(snapshotManager.snapshot(id));
+            if (snapshotManager.snapshotExists(id)) {
+                snapshots.add(snapshotManager.snapshot(id));
+            }

Review Comment:
   If a dirty commit occurs, the previous processing logic throws an exception, 
which affects the running of the test case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to