JingsongLi commented on code in PR #3826:
URL: https://github.com/apache/paimon/pull/3826#discussion_r1694413588
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonBaseScan.scala:
##########
@@ -127,7 +127,9 @@ abstract class PaimonBaseScan(
override def estimateStatistics(): Statistics = {
val stats = PaimonStatistics(this)
- if (reservedFilters.nonEmpty) {
+ // When statistics doesn't exist, we don't need to perform
FilterEstimation on stats,
+ // because in this scenario stats is calculated through splits and
partition pruning has been done.
+ if (statistics.isPresent && reservedFilters.nonEmpty) {
Review Comment:
It is better to merge `PaimonStatistics` and here, we'd better maintain only
one judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
