Aitozi commented on code in PR #3853:
URL: https://github.com/apache/paimon/pull/3853#discussion_r1697032512


##########
paimon-core/src/main/java/org/apache/paimon/mergetree/LookupLevels.java:
##########
@@ -207,12 +211,8 @@ private LookupFile createLookupFile(DataFileMeta file) 
throws IOException {
         return new LookupFile(localFile, file, 
lookupStoreFactory.createReader(localFile, context));
     }
 
-    @Override
-    public void close() throws IOException {

Review Comment:
   In 
[here](https://github.com/apache/paimon/blob/e58197986a8d5a1fc3ca21b176be121b62dd9b57/paimon-core/src/main/java/org/apache/paimon/operation/KeyValueFileStoreWrite.java#L382)
 . And if a partition bucket writer is idle and closed, the lookup file for 
this writer will only be evicted based on size or LRU (there is no explicit 
close for this situation).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to