Aitozi commented on code in PR #41:
URL: https://github.com/apache/paimon-rust/pull/41#discussion_r1703460995
##########
crates/paimon/src/spec/snapshot.rs:
##########
@@ -39,6 +39,16 @@ pub struct Snapshot {
#[builder(default = None)]
index_manifest: Option<String>,
commit_user: String,
+ // Mainly for snapshot deduplication.
+ //
+ // If multiple snapshots have the same commitIdentifier, reading from any
of these snapshots
Review Comment:
I have a question out of this PR, Currently, the overwrite (expire
partition) share the same commit identifier with the current snapshots's
commit identifier. So I think this comments may not right ? CC @JingsongLi
##########
crates/paimon/src/spec/snapshot.rs:
##########
@@ -39,6 +39,16 @@ pub struct Snapshot {
#[builder(default = None)]
index_manifest: Option<String>,
commit_user: String,
+ // Mainly for snapshot deduplication.
+ //
+ // If multiple snapshots have the same commitIdentifier, reading from any
of these snapshots
Review Comment:
I have a question out of this PR. Currently, the overwrite (expire
partition) share the same commit identifier with the current snapshots's
commit identifier. So I think this comments may not right ? CC @JingsongLi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
