dbac commented on code in PR #3866:
URL: https://github.com/apache/paimon/pull/3866#discussion_r1713971706
##########
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java:
##########
@@ -74,8 +77,34 @@ public static ByteBuffer toByteBuffer(DataType type, Object
value) {
case DECIMAL:
Decimal decimal = (Decimal) value;
return ByteBuffer.wrap((decimal.toUnscaledBytes()));
+ case TIMESTAMP_WITHOUT_TIME_ZONE:
+ TimestampType timestampType = (TimestampType) type;
+ return convertTimestampWithPrecisionToBuffer(
+ (Timestamp) value, timestampType.getPrecision());
+ case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
+ LocalZonedTimestampType localTimestampType =
(LocalZonedTimestampType) type;
+ return convertTimestampWithPrecisionToBuffer(
+ (Timestamp) value, localTimestampType.getPrecision());
+ case TIME_WITHOUT_TIME_ZONE:
+ long microsecondsFromMidnight = (Integer) value / 1_000;
Review Comment:
I saw a source code serialization that was written as an int，So it turns
into an int
I was weird, too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
