devillove084 commented on code in PR #51:
URL: https://github.com/apache/paimon-rust/pull/51#discussion_r1719762990
##########
crates/paimon/src/io/file_io.rs:
##########
@@ -129,10 +148,15 @@ impl FileIO {
/// Delete a dir recursively.
///
/// Reference:
<https://github.com/apache/paimon/blob/release-0.8.2/paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java#L139>
- pub async fn delete_dir(&self, path: &str) -> Result<()> {
- self.op.remove_all(path).await.context(IoUnexpectedSnafu {
- message: "Failed to delete dir".to_string(),
- })?;
+ pub async fn delete_dir(&self, path: impl AsRef<str>) -> Result<()> {
+ let (op, relative_path) = self.inner_storage.create_operator(&path)?;
+
+ op.remove_all(relative_path)
+ .await
+ .context(IoUnexpectedSnafu {
+ message: "opendal delete directory failed",
Review Comment:
Yes, this should be the same problem as the dependency of the Url library
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
