ulysses-you commented on code in PR #3981:
URL: https://github.com/apache/paimon/pull/3981#discussion_r1721477059
##########
paimon-core/src/main/java/org/apache/paimon/catalog/Catalog.java:
##########
@@ -84,10 +85,23 @@ default Optional<MetastoreClient.Factory>
metastoreClientFactory(Identifier iden
/**
* Get the names of all databases in this catalog.
*
- * @return a list of the names of all databases
+ * @return a list of the names of user databases
*/
List<String> listDatabases();
Review Comment:
@JingsongLi How about change ` List<String> listDatabases();` to `
List<String> listDatabases(boolean includeSystem);`? I'm afraid always return
sys database will break somethings. I beleive the usage of `listDatabases`
Paimon internal do not need sys database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
