JingsongLi commented on code in PR #4047:
URL: https://github.com/apache/paimon/pull/4047#discussion_r1728544067
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -819,6 +819,20 @@ private void updateHmsTable(Table table, Identifier
identifier, TableSchema sche
private void updateHmsTablePars(Table table, TableSchema schema) {
if (syncAllProperties()) {
table.getParameters().putAll(schema.options());
+ if (!schema.primaryKeys().isEmpty()) {
Review Comment:
Please extract a method to reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]