JingsongLi commented on code in PR #4154:
URL: https://github.com/apache/paimon/pull/4154#discussion_r1751526854
##########
paimon-common/src/main/java/org/apache/paimon/codegen/CodeGenerator.java:
##########
@@ -48,12 +48,7 @@ GeneratedClass<NormalizedKeyComputer>
generateNormalizedKeyComputer(
GeneratedClass<RecordComparator> generateRecordComparator(
List<DataType> inputTypes, int[] sortFields);
- /**
- * Generate a {@link RecordEqualiser}.
- *
- * @param fieldTypes Both the input row field types and the sort key field
types. Records are *
- * compared by the first field, then the second field, then the third
field and so on. All *
- * fields are compared in ascending order.
- */
- GeneratedClass<RecordEqualiser> generateRecordEqualiser(List<DataType>
fieldTypes);
+ /** Generate a {@link RecordEqualiser} with fields. */
Review Comment:
I think fields (in equal context) is enough to explain.
##########
paimon-common/src/main/java/org/apache/paimon/codegen/CodeGenerator.java:
##########
@@ -48,12 +48,7 @@ GeneratedClass<NormalizedKeyComputer>
generateNormalizedKeyComputer(
GeneratedClass<RecordComparator> generateRecordComparator(
List<DataType> inputTypes, int[] sortFields);
- /**
- * Generate a {@link RecordEqualiser}.
- *
- * @param fieldTypes Both the input row field types and the sort key field
types. Records are *
- * compared by the first field, then the second field, then the third
field and so on. All *
- * fields are compared in ascending order.
- */
- GeneratedClass<RecordEqualiser> generateRecordEqualiser(List<DataType>
fieldTypes);
+ /** Generate a {@link RecordEqualiser} with fields. */
Review Comment:
I think `fields` this name (in equal context) is enough to explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
