wwj6591812 commented on code in PR #4243: URL: https://github.com/apache/paimon/pull/4243#discussion_r1772822612
########## paimon-common/src/main/java/org/apache/paimon/TableType.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon; + +import org.apache.paimon.options.description.DescribedEnum; +import org.apache.paimon.options.description.InlineElement; + +import static org.apache.paimon.options.description.TextElement.text; + +/** Type of the table. */ +public enum TableType implements DescribedEnum { + TABLE("table", "Normal Paimon table."), Review Comment: where is 'Flink materialized table'? ########## paimon-common/src/main/java/org/apache/paimon/TableType.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon; + +import org.apache.paimon.options.description.DescribedEnum; +import org.apache.paimon.options.description.InlineElement; + +import static org.apache.paimon.options.description.TextElement.text; + +/** Type of the table. */ +public enum TableType implements DescribedEnum { + TABLE("table", "Normal Paimon table."), + FORMAT_TABLE( + "format-table", + "A file format table refers to a directory that contains multiple files of the same format."); + + private final String value; + private final String description; + + TableType(String value, String description) { + this.value = value; + this.description = description; + } + + @Override + public String toString() { + return value; + } + + @Override + public InlineElement getDescription() { + return text(description); + } + + public static TableType fromString(String name) { + for (TableType type : TableType.values()) { + if (type.value.equals(name)) { + return type; + } + } + throw new UnsupportedOperationException("Unknown type: " + name); Review Comment: change "Unknown type" to "Unknown table type"? ########## paimon-common/src/main/java/org/apache/paimon/CoreOptions.java: ########## @@ -87,6 +87,12 @@ public class CoreOptions implements Serializable { public static final String COLUMNS = "columns"; + public static final ConfigOption<TableType> TYPE = + key("type") Review Comment: Change key("type") to key("table-type")? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
